Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vale #103

Merged
merged 18 commits into from
Feb 9, 2024
Merged

Vale #103

merged 18 commits into from
Feb 9, 2024

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented Jan 17, 2024 •
edited
Loading

Add a linter for prose in markdown files, see https://vale.sh/

Type of change

  • New feature or functionality (change which adds functionality)

For changes visible to end-users

  • Relevant documentation has been updated

Test plan

  • Covered by existing test cases
  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

@alexeagle alexeagle requested a review from mattem February 7, 2024 01:45
@alexeagle
Copy link
Member Author

@mattem since our linting is based on visiting targets, we need users to declare their Markdown files in some library rule.
@dwtj did something like that in https://github.com/dwtj/dwtj_rules_markdown - not sure if we want to introduce something similar.

For now I've used a filegroup with tags = ["markdown"] which I think is maybe a viable option?

@alexeagle alexeagle marked this pull request as ready for review February 9, 2024 01:35
@alexeagle alexeagle requested a review from jbedard February 9, 2024 19:53
alexeagle
alexeagle commented Feb 9, 2024
View reviewed changes
@alexeagle alexeagle merged commit 0de7861 into main Feb 9, 2024
8 checks passed
@alexeagle alexeagle deleted the vale branch February 9, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattem mattem mattem approved these changes

@jbedard jbedard Awaiting requested review from jbedard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @mattem